Introduce new AccessType to allow a set of addresses #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #974 +/- ##
==========================================
+ Coverage 59.29% 60.48% +1.18%
==========================================
Files 51 51
Lines 6238 6311 +73
==========================================
+ Hits 3699 3817 +118
+ Misses 2272 2224 -48
- Partials 267 270 +3
|
ethanfrey
approved these changes
Sep 5, 2022
| @@ -19,12 +19,16 @@ enum AccessType { | |||
| // AccessTypeNobody forbidden | |||
| ACCESS_TYPE_NOBODY = 1 | |||
| [ (gogoproto.enumvalue_customname) = "AccessTypeNobody" ]; | |||
| // AccessTypeOnlyAddress restricted to an address | |||
| // AccessTypeOnlyAddress restricted to a single address | |||
| // Deprecated: use AccessTypeAnyOfAddresses instead | |||
There was a problem hiding this comment.
Why deprecate?
I think it is fine to use the simpler version for the cases where it works
alpe
force-pushed
the
945_access_config_anyof
branch
from
8004bde
to
089076d
Compare
3 tasks
jhernandezb
approved these changes
Sep 7, 2022
| Short: "Submit an update instantiate config proposal.", | ||
| Args: cobra.MinimumNArgs(1), | ||
| Long: strings.TrimSpace( | ||
| fmt.Sprintf(`Submit an update instantiate config proposal for multiple code ids. | ||
|
|
||
| Example: | ||
| $ %s tx gov submit-proposal update-instantiate-config 1,nobody 2,everybody 3,%s1l2rsakp388kuv9k8qzq6lrm9taddae7fpx59wm | ||
| `, version.AppName, bech32Prefix)), | ||
| $ %s tx gov submit-proposal update-instantiate-config 1:nobody 2:everybody 3:%s1l2rsakp388kuv9k8qzq6lrm9taddae7fpx59wm,%s1vx8knpllrj7n963p9ttd80w47kpacrhuts497x |
There was a problem hiding this comment.
Nice! I think this should work fine.
| }, | ||
| } | ||
| for name, spec := range specs { | ||
| t.Run(name, func(t *testing.T) { |
|
Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #945
Introduces a new Access type to allow a set of addresses to accept.
This PR includes a small but breaking change to the CLI. The separator char between codeID and permission is
:now:Before:
Now:
wasmd tx gov submit-proposal update-instantiate-config 1:nobody 2:everybody 3:wasm1l2rsakp388kuv9k8qzq6lrm9taddae7fpx59wm,wasm1vx8knpllrj7n963p9ttd80w47kpacrhuts497x`AccessConfig.AddressintoAccessConfig.Addressessee proto? - keep and remove in a future version