Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent migration to a restricted code #900

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Prevent migration to a restricted code #900

merged 1 commit into from
Aug 15, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jul 8, 2022

On migration, the permissions for the target contract were not checked proper.

@alpe alpe requested a review from pinosu July 8, 2022 11:24
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #900 (ffd8a3c) into main (3787f3d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
- Coverage   59.19%   59.18%   -0.02%     
==========================================
  Files          51       51              
  Lines        6196     6198       +2     
==========================================
  Hits         3668     3668              
- Misses       2262     2263       +1     
- Partials      266      267       +1     
Impacted Files Coverage Δ
x/wasm/keeper/contract_keeper.go 92.85% <ø> (ø)
x/wasm/keeper/keeper.go 88.27% <100.00%> (-0.30%) ⬇️

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! lgtm 👍

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one

@ethanfrey ethanfrey merged commit f14c469 into main Aug 15, 2022
@ethanfrey ethanfrey deleted the migration_fix branch August 15, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants