Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish protobufs on release tags #869

Merged
merged 2 commits into from
May 20, 2022
Merged

Publish protobufs on release tags #869

merged 2 commits into from
May 20, 2022

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented May 19, 2022 •
edited
Loading

Publish protobufs when:

  • A new commit is pushed into main (only if files in proto folder are modified)
  • A new release tag event is triggered

@pinosu pinosu requested a review from alpe as a code owner May 19, 2022 13:54
@pinosu
Copy link
Contributor Author

pinosu commented May 19, 2022

@alpe this is how cosmos-sdk will approach protobuf publishing. Should we follow the same path or we go with this solution since we might have backwards compatibility breaking changes and later on upgrade to the same approach adopted by cosmos-sdk?

alpe
alpe approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor comment for RC versions

.github/workflows/proto-buf-publisher.yml Outdated Show resolved Hide resolved
@pinosu pinosu merged commit aadc8bf into main May 20, 2022
conorpp pushed a commit to wormhole-foundation/wasmd that referenced this pull request Sep 2, 2022
@pinosu @conorpp
Publish protobufs on release tags (CosmWasm#869)
95ce8b7 
* Publish protobufs on release tags

* Fix regex to match also rc versions
@alpe alpe deleted the fix-protobuf-publish branch May 10, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe alpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinosu @alpe