Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused flags from cmd prompt #650

Merged

Conversation

fkneeland-figure
Copy link
Contributor

Source and builder properties were removed from the protos but the Use line of the command still references these.

Issue: #647

@fkneeland-figure
Copy link
Contributor Author

@alpe This is ready for review

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #650 (fe7ee71) into master (6a471a4) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   60.21%   60.21%           
=======================================
  Files          48       48           
  Lines        5313     5313           
=======================================
  Hits         3199     3199           
  Misses       1889     1889           
  Partials      225      225           
Impacted Files Coverage Δ
x/wasm/client/cli/gov_tx.go 0.00% <0.00%> (ø)
x/wasm/client/cli/genesis_msg.go 70.54% <100.00%> (ø)

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Alex is back next week.
Happy to merge some of the smaller prs in the meantime

@ethanfrey ethanfrey merged commit d82a0b9 into CosmWasm:master Oct 15, 2021
@alpe
Copy link
Contributor

alpe commented Oct 18, 2021

Thanks addressing this! 💯
I think this PR qualifies for some swag on Cosmos codefest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants