Implement tx counter for transaction info #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ethanfrey
approved these changes
Sep 27, 2021
app/ante.go
Outdated
| ante.NewSigGasConsumeDecorator(ak, sigGasConsumer), | ||
| ante.NewSigVerificationDecorator(ak, signModeHandler), | ||
| ante.NewIncrementSequenceDecorator(ak), | ||
| wasmkeeper.NewCountTXDecorator(txCounterStoreKey), |
There was a problem hiding this comment.
We should add some note that chains using x/wasm need to add this custom AnteHandler if they want Tx Index info.
Not sure where that goes? Integration.md?
|
Please make sure to tick the box in #618 after merging |
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
==========================================
+ Coverage 60.04% 60.39% +0.34%
==========================================
Files 45 48 +3
Lines 5209 5254 +45
==========================================
+ Hits 3128 3173 +45
Misses 1859 1859
Partials 222 222
|
ethanfrey
approved these changes
Sep 27, 2021
| @@ -63,6 +63,10 @@ from the Cosmos SDK, and enabled them in `app.go`. If so, you can just look | |||
| at [`wasmd/app/app.go`](https://github.com/CosmWasm/wasmd/blob/master/app/app.go#) | |||
| for how to do so (just search there for lines with `wasm`). | |||
|
|
|||
| `wasmd` also comes with a custom `ante handler` that adds the TX position in the block into the context | |||
| @@ -8,7 +8,7 @@ echo "## Add new CosmWasm contract" | |||
| RESP=$(wasmd tx wasm store "$DIR/../../x/wasm/keeper/testdata/hackatom.wasm" \ | |||
| --from validator --gas 1500000 -y --chain-id=testing --node=http://localhost:26657 -b block) | |||
|
|
|||
| CODE_ID=$(echo "$RESP" | jq -r '.logs[0].events[0].attributes[-1].value') | |||
| CODE_ID=$(echo "$RESP" | jq -r '.logs[0].events[1].attributes[-1].value') | |||
There was a problem hiding this comment.
The ante handler added an event?
Or this is just an older bug you just found?
There was a problem hiding this comment.
This was a 🐛 that I found with manual tests. Not related to the ante handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #601
Based on the #608 spike
Changes:
uint32for the tx counter0counter but empty TransactionInfo on simulations