Add organisation to grpc gateway path #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpe
force-pushed
the
grpc_gateway_path
branch
3 times, most recently
from
7c8dd09
to
cbbd55f
Compare
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
==========================================
- Coverage 59.71% 59.67% -0.04%
==========================================
Files 45 45
Lines 5208 5208
==========================================
- Hits 3110 3108 -2
- Misses 1874 1875 +1
- Partials 224 225 +1
|
webmaster128
approved these changes
Aug 4, 2021
ethanfrey
approved these changes
Aug 4, 2021
CHANGELOG.md
Outdated
| @@ -15,9 +15,15 @@ | |||
| [\#565](https://github.com/CosmWasm/wasmd/pull/565) | |||
|
|
|||
| **Implemented Enhancements:** | |||
|
|
|||
| - Wasmvm upgrade 557 [\#559](https://github.com/CosmWasm/wasmd/pull/559) ([ethanfrey](https://github.com/ethanfrey)) | |||
There was a problem hiding this comment.
Thanks for adding the changeling
| @@ -6,26 +6,26 @@ DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)" | |||
| echo "-----------------------" | |||
| PROTO_THRD="$DIR/../../third_party/proto" | |||
| PROTO_WASMD="$DIR/../../proto" | |||
| PROTO_WASMD_QUERY="$PROTO_WASMD/cosmwasm/wasm/v1beta1/query.proto" | |||
| PROTO_WASMD_QUERY="$PROTO_WASMD/cosmwasm/wasm/v1/query.proto" | |||
| @@ -46,11 +47,11 @@ service Query { | |||
| } | |||
| // Code gets the binary code and metadata for a singe wasm code | |||
| rpc Code(QueryCodeRequest) returns (QueryCodeResponse) { | |||
| option (google.api.http).get = "/wasm/v1/code/{code_id}"; | |||
| option (google.api.http).get = "/cosmwasm/wasm/v1/code/{code_id}"; | |||
There was a problem hiding this comment.
Make sense. This is REST path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a convention used in the cosmos-sdk
The GRPC gateway is a generated REST interface that is translates queries/responses into/from protobuf.