-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add organisation to grpc gateway path #578
Conversation
7c8dd09
to
cbbd55f
Compare
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
==========================================
- Coverage 59.71% 59.67% -0.04%
==========================================
Files 45 45
Lines 5208 5208
==========================================
- Hits 3110 3108 -2
- Misses 1874 1875 +1
- Partials 224 225 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This does not affect CosmJS at all because the querry types are already in cosmwasm/wasm/v1/query
. It only affects the LCD API, which we do not use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
CHANGELOG.md
Outdated
@@ -15,9 +15,15 @@ | |||
[\#565](https://github.com/CosmWasm/wasmd/pull/565) | |||
|
|||
**Implemented Enhancements:** | |||
|
|||
- Wasmvm upgrade 557 [\#559](https://github.com/CosmWasm/wasmd/pull/559) ([ethanfrey](https://github.com/ethanfrey)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the changeling
@@ -6,26 +6,26 @@ DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)" | |||
echo "-----------------------" | |||
PROTO_THRD="$DIR/../../third_party/proto" | |||
PROTO_WASMD="$DIR/../../proto" | |||
PROTO_WASMD_QUERY="$PROTO_WASMD/cosmwasm/wasm/v1beta1/query.proto" | |||
PROTO_WASMD_QUERY="$PROTO_WASMD/cosmwasm/wasm/v1/query.proto" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff here
@@ -46,11 +47,11 @@ service Query { | |||
} | |||
// Code gets the binary code and metadata for a singe wasm code | |||
rpc Code(QueryCodeRequest) returns (QueryCodeResponse) { | |||
option (google.api.http).get = "/wasm/v1/code/{code_id}"; | |||
option (google.api.http).get = "/cosmwasm/wasm/v1/code/{code_id}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense. This is REST path.
This is a convention used in the cosmos-sdk
The GRPC gateway is a generated REST interface that is translates queries/responses into/from protobuf.