-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize address derivation #565
Conversation
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 59.65% 59.71% +0.05%
==========================================
Files 45 45
Lines 5260 5277 +17
==========================================
+ Hits 3138 3151 +13
- Misses 1892 1894 +2
- Partials 230 232 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. The derives addresses match my implementation in cosmos/cosmjs#857
Only the modularity point below. We use ADR-20 and truncate its output instead of having a different implementation, which makes things much nicer.
4fbb945
to
6f720a4
Compare
Closes #410