Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize address derivation #565

Merged
merged 6 commits into from
Jul 28, 2021
Merged

Conversation

ethanfrey
Copy link
Member

Closes #410

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #565 (4fbb945) into master (a012e00) will increase coverage by 0.05%.
The diff coverage is 92.00%.

❗ Current head 4fbb945 differs from pull request most recent head 6f720a4. Consider uploading reports for the commit 6f720a4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
+ Coverage   59.65%   59.71%   +0.05%     
==========================================
  Files          45       45              
  Lines        5260     5277      +17     
==========================================
+ Hits         3138     3151      +13     
- Misses       1892     1894       +2     
- Partials      230      232       +2     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 85.11% <90.47%> (-0.28%) ⬇️
x/wasm/types/test_fixtures.go 95.12% <100.00%> (ø)

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. The derives addresses match my implementation in cosmos/cosmjs#857

Only the modularity point below. We use ADR-20 and truncate its output instead of having a different implementation, which makes things much nicer.

x/wasm/keeper/keeper.go Outdated Show resolved Hide resolved
@ethanfrey ethanfrey force-pushed the 410-standardize-address-derivation branch from 4fbb945 to 6f720a4 Compare July 28, 2021 09:19
@ethanfrey ethanfrey merged commit 6f684d5 into master Jul 28, 2021
@ethanfrey ethanfrey deleted the 410-standardize-address-derivation branch July 28, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Contract Address Derivation
2 participants