Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new interfaces for extendability #471

Merged
merged 4 commits into from
Mar 29, 2021
Merged

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Mar 22, 2021

Refactoring towards a more modular design.

  • New interfaces in x/wasm/types/exported_keepers.go
  • PermissionedKeeper decorates the keeper with authorization policies and provides public methods to provision or interact with a contract
  • Minor bugfix for registering proposal types with amino
  • Emit multiple events for pin/unpin instead of list attribute

@alpe alpe requested a review from ethanfrey March 22, 2021 15:12
@alpe alpe marked this pull request as draft March 22, 2021 15:13
@alpe alpe removed the request for review from ethanfrey March 22, 2021 15:13
@alpe alpe added the extension point Makes the system easier to extend or test label Mar 22, 2021
@alpe alpe force-pushed the extendable_keeper branch from ea33f64 to c803f34 Compare March 22, 2021 16:53
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #471 (48df71f) into master (388469c) will increase coverage by 0.04%.
The diff coverage is 85.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
+ Coverage   56.76%   56.81%   +0.04%     
==========================================
  Files          40       41       +1     
  Lines        4385     4390       +5     
==========================================
+ Hits         2489     2494       +5     
- Misses       1685     1686       +1     
+ Partials      211      210       -1     
Impacted Files Coverage Δ
x/wasm/handler.go 74.28% <ø> (ø)
x/wasm/keeper/msg_server.go 0.00% <ø> (ø)
x/wasm/keeper/options.go 73.33% <ø> (ø)
x/wasm/keeper/query_plugins.go 76.51% <ø> (ø)
x/wasm/types/keys.go 38.23% <ø> (ø)
x/wasm/ibc.go 59.37% <50.00%> (ø)
x/wasm/keeper/genesis.go 88.05% <50.00%> (+0.18%) ⬆️
x/wasm/keeper/keeper.go 86.00% <60.00%> (-0.12%) ⬇️
x/wasm/keeper/querier.go 50.81% <75.00%> (ø)
x/wasm/keeper/legacy_querier.go 68.75% <83.33%> (ø)
... and 8 more

@alpe alpe force-pushed the extendable_keeper branch from c803f34 to 55ac19b Compare March 24, 2021 13:12
@alpe alpe marked this pull request as ready for review March 25, 2021 15:15
@alpe alpe requested a review from ethanfrey March 29, 2021 07:11
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few minor comments, but does make extensibility points much clearer.

x/wasm/handler.go Show resolved Hide resolved
x/wasm/ibc.go Show resolved Hide resolved
x/wasm/keeper/contract_keeper.go Show resolved Hide resolved
x/wasm/types/exported_keepers.go Show resolved Hide resolved
x/wasm/types/proposal.go Show resolved Hide resolved
@ethanfrey ethanfrey merged commit d9ca5d8 into master Mar 29, 2021
@ethanfrey ethanfrey deleted the extendable_keeper branch March 29, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension point Makes the system easier to extend or test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants