-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ibc query support #439
Ibc query support #439
Conversation
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
- Coverage 55.44% 54.58% -0.86%
==========================================
Files 39 39
Lines 4080 4109 +29
==========================================
- Hits 2262 2243 -19
- Misses 1627 1671 +44
- Partials 191 195 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments only. Looks good 🌻
I'd like to make a few changes to the query types as mentioned above. Do you think those are good?
|
|
4e2c4cb
to
9ce450a
Compare
Closes #434
Code "complete", but needs testing
The
IbcQuery.Channels
variant doesn't seem to match what we can get from the IBC Keeper (we cannot filter by port). This will be very expensive to call.Let us reconsider what we want to do here. We can still modify the queries we expose to the contracts (remove or adjust them). CosmWasm is still in
-alpha2
, so we can change types.