Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename protobuf package #330

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Rename protobuf package #330

merged 1 commit into from
Dec 4, 2020

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Dec 3, 2020

Resolves #329

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #330 (2a105ad) into master (eeb3797) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   69.68%   69.76%   +0.08%     
==========================================
  Files          28       28              
  Lines        2421     2421              
==========================================
+ Hits         1687     1689       +2     
+ Misses        616      615       -1     
+ Partials      118      117       -1
Impacted Files Coverage Δ
x/wasm/internal/keeper/keeper.go 90.56% <0.00%> (+0.58%) ⬆️

ethanfrey
ethanfrey approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Please add an entry for the changelog (this is client breaking, right?)

@alpe
Copy link
Contributor Author

alpe commented Dec 4, 2020

Will address the changelog with #331

@alpe alpe merged commit 576f620 into master Dec 4, 2020
@alpe alpe deleted the proto_package_329 branch December 4, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change proto package to match <organisation>.<module>.<version>
2 participants
@alpe @ethanfrey