Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base request data for sender #325

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Use base request data for sender #325

merged 1 commit into from
Nov 30, 2020

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 25, 2020

Resolves #324

@alpe alpe requested a review from orkunkl November 25, 2020 10:06
webmaster128
webmaster128 approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go in a 0.12.2 patch release?

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #325 (0b7b703) into master (b0b407d) will increase coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   69.46%   70.51%   +1.04%     
==========================================
  Files          28       28              
  Lines        2404     2357      -47     
==========================================
- Hits         1670     1662       -8     
+ Misses        616      578      -38     
+ Partials      118      117       -1
Impacted Files Coverage Δ
x/wasm/internal/types/types.go 27.77% <0.00%> (+4.24%) ⬆️

@alpe alpe merged commit ccc378e into master Nov 30, 2020
@alpe alpe deleted the fix_rest_sender_324 branch November 30, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orkunkl orkunkl orkunkl approved these changes

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REST handler wrong Sender source
3 participants
@alpe @webmaster128 @orkunkl