-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containerized Protobuf generation #304
Conversation
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 17.49% 17.51% +0.01%
==========================================
Files 35 35
Lines 10505 10505
==========================================
+ Hits 1838 1840 +2
+ Misses 8566 8565 -1
+ Partials 101 100 -1
Continue to review full report at Codecov.
|
@@ -198,16 +203,19 @@ format: | |||
############################################################################### | |||
|
|||
proto-all: proto-gen proto-lint proto-check-breaking | |||
.PHONY: proto-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Much better maintainable than a one-line .PHONY. Did now know you can specily multiple .PHONY. But people on the internet say this is how you do it (https://stackoverflow.com/questions/4156382/is-it-possible-to-have-multiple-phony-targets-in-a-gnu-makefile)
--grpc-gateway_opt paths=Mgoogle/protobuf/any.proto=github.com/cosmos/cosmos-sdk/codec/types,Mgoogle/protobuf/empty.proto=github.com/gogo/protobuf/types,paths=source_relative \ | ||
--doc_out=./doc \ | ||
--doc_opt=markdown,proto.md \ | ||
$(find "${PROJECT_PROTO_DIR}" -maxdepth 1 -name '*.proto') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script is executed by the developer who changes the .proto files and the docs are checked-in along with the proto changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, generated files are checked into the repo.
Co-authored-by: Simon Warta <[email protected]>
Co-authored-by: Simon Warta <[email protected]>
Co-authored-by: Simon Warta <[email protected]>
Co-authored-by: Simon Warta <[email protected]>
Resolves #295
This PR contains:
cosmwasm/prototools-docker
-> contrib/prototools-docker/Dockerfilemake proto-gen
for generation andmake proto-lint
for Buf linter