Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Stargate RC2 #299

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Upgrade to Stargate RC2 #299

merged 1 commit into from
Nov 5, 2020

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 3, 2020

Stargate RC2

Left to do:

  • manual smoke tests

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #299 into master will decrease coverage by 0.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
- Coverage   17.26%   17.25%   -0.02%     
==========================================
  Files          34       35       +1     
  Lines       10412    10463      +51     
==========================================
+ Hits         1798     1805       +7     
- Misses       8518     8562      +44     
  Partials       96       96              
Impacted Files Coverage Δ
app/genesis.go 100.00% <ø> (ø)
x/wasm/internal/types/msg.pb.go 0.55% <ø> (ø)
x/wasm/internal/types/types.pb.go 0.75% <0.00%> (-0.02%) ⬇️
x/wasm/module.go 14.28% <ø> (ø)
app/test_helpers.go 12.50% <12.50%> (ø)
app/export.go 13.18% <40.00%> (-0.15%) ⬇️
app/app.go 88.47% <66.66%> (-0.74%) ⬇️
x/wasm/internal/types/msg.go 64.63% <66.66%> (ø)
x/wasm/internal/keeper/test_common.go 93.23% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1846f62...bf83c44. Read the comment docs.

@alpe alpe marked this pull request as ready for review November 3, 2020 17:38
@alpe alpe requested a review from ethanfrey November 3, 2020 17:38
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the diff and seems good.

@alpe alpe merged commit 41cf73d into master Nov 5, 2020
@alpe alpe deleted the upgrade_starport_rc2 branch November 5, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants