Add customizable WasmLimits

[chipshort]

closes #1986

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.64%. Comparing base (81c1eb0) to head (f79b23f).

Files with missing lines	Patch %	Lines
x/wasm/keeper/querier.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1989      +/-   ##
==========================================
- Coverage   48.66%   48.64%   -0.02%     
==========================================
  Files          65       65              
  Lines       10036    10040       +4     
==========================================
  Hits         4884     4884              
- Misses       4718     4722       +4     
  Partials      434      434              

Files with missing lines	Coverage Δ
x/wasm/keeper/querier.go	76.39% <0.00%> (-1.02%)	⬇️

[chipshort]

obviously not mergeable yet, but would love some feedback from you @pinosu

[pinosu]

Nice work!
I'm still thinking if it's best to have the wasmLimits in wasmConfig or add a new paramenter to the NewKeeper func . I guess we need to think about the scope of the two things and if they can match or just have similar names.

[pinosu]

Do we have a specific struct that we can define for config or we want to keep it flexible?
In that case, we could evaluate using bytes instead of string. WDYT?

[chipshort]

As mentioned in our chat, I want to keep it flexible. The reason for string instead of bytes is that I want to make it easy for contract devs to copy and paste the limits. They need pass them into cosmwasm-check. See here: https://github.com/CosmWasm/cosmwasm/blob/cf413c5ad6a58a87e0be894584f01506f3b2e0af/packages/check/src/main.rs#L41-L50

[pinosu]

Nice!

[pinosu]

Great work!
Should we also define DefaultVMConfig(), with the limits set o some reasonable default value?

[chipshort]

Should we also define DefaultVMConfig(), with the limits set o some reasonable default value?

This is handled in cosmwasm-vm because I want to avoid chain developers forgetting to set one of the values to the default. That's why the values all use pointers. If you pass a nil ptr, cosmwasm-vm uses the default value.