Add msg update contract label #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1640 +/- ##
==========================================
- Coverage 56.03% 55.96% -0.07%
==========================================
Files 64 64
Lines 8996 9062 +66
==========================================
+ Hits 5041 5072 +31
- Misses 3514 3546 +32
- Partials 441 444 +3
|
alpe
approved these changes
Sep 28, 2023
| @@ -157,3 +157,31 @@ func UpdateInstantiateConfigCmd() *cobra.Command { | |||
| flags.AddTxFlagsToCmd(cmd) | |||
| return cmd | |||
| } | |||
|
|
|||
| // UpdateContractLabelCmd sets an new label for a contract | |||
| func UpdateContractLabelCmd() *cobra.Command { | |||
| types.EventTypeUpdateContractLabel, | ||
| sdk.NewAttribute(types.AttributeKeyContractAddr, contractAddress.String()), | ||
| sdk.NewAttribute(types.AttributeKeyNewLabel, newLabel), | ||
| )) |
| "update label - gov policy": { | ||
| newLabel: "new label", | ||
| policy: GovAuthorizationPolicy{}, | ||
| caller: example.CreatorAddr, |
There was a problem hiding this comment.
When you use a random caller address, then it would ensure the different behaviour of the gov policy
| assert.Equal(t, exp, attrsToStringMap(em.Events()[0].Attributes)) | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
Good tests! For bonus points, there is also the unknown contract address scenario that must not panic.
| return nil, err | ||
| } | ||
|
|
||
| return &types.MsgUpdateContractLabelResponse{}, nil |
| addr: myAddress.String(), | ||
| expErr: false, | ||
| }, | ||
| "other address cannot update contract label": { |
There was a problem hiding this comment.
🤔 good to have the scenarios covered but there is some overlap with the keeper tests.
The integration tests give more confidence on the whole process. If you see value in both, then we can keep them.
| addr: otherAddr.String(), | ||
| expErr: true, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Please check for invalid data
| } | ||
| }) | ||
| } | ||
| } |
| @@ -79,6 +80,7 @@ func RegisterInterfaces(registry types.InterfaceRegistry) { | |||
| &MsgAddCodeUploadParamsAddresses{}, | |||
| &MsgRemoveCodeUploadParamsAddresses{}, | |||
| &MsgStoreAndMigrateContract{}, | |||
| &MsgUpdateContractLabel{}, | |||
| expErr: true, | ||
| }, | ||
| } | ||
| for msg, spec := range specs { |
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
* Add msg update contract label * fix tests (cherry picked from commit e654808) # Conflicts: # x/wasm/keeper/keeper.go # x/wasm/types/tx.pb.go
pinosu
added a commit
that referenced
this pull request
Sep 28, 2023
* Add msg update contract label (#1640) * Add msg update contract label * fix tests (cherry picked from commit e654808) # Conflicts: # x/wasm/keeper/keeper.go # x/wasm/types/tx.pb.go * Fix conflicts --------- Co-authored-by: pinosu <[email protected]> Co-authored-by: Pino' Surace <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1601