Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor chore #1522

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Minor chore #1522

merged 2 commits into from
Jul 19, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jul 19, 2023

Minor updates

  • extract contains helper method
  • additional test cases

@alpe alpe requested a review from pinosu July 19, 2023 13:09
@alpe alpe requested a review from pinosu July 19, 2023 13:42
@pinosu pinosu merged commit 9276699 into 1491-add_remove_anyofaddr_proposal Jul 19, 2023
3 checks passed
@pinosu pinosu deleted the 1491-add_remove_anyofaddr_proposal_alex1 branch July 19, 2023 13:56
alpe added a commit that referenced this pull request Jul 19, 2023
@pinosu @alpe
Add/Remove addresses for code upload params (#1493)
19c17cb 
* Start implementation

* Add tests

* Add fix

* Fix comments

* Minor chore (#1522)

* Minor chore

* Remove duplicate tests

---------

Co-authored-by: Alexander Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @pinosu