Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make system tests extendable for other app binaries #1503

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jul 14, 2023

Support other binaries via parameter

  • less noise on test error output

 Please enter the commit message for your changes. Lines starting
@alpe alpe requested a review from pinosu July 14, 2023 13:43
@alpe alpe self-assigned this Jul 14, 2023
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💯 LGTM 👍

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1503 (d7df231) into main (52a7a6a) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1503      +/-   ##
==========================================
- Coverage   58.17%   58.15%   -0.03%     
==========================================
  Files          64       64              
  Lines        8460     8460              
==========================================
- Hits         4922     4920       -2     
- Misses       3130     3131       +1     
- Partials      408      409       +1     

see 1 file with indirect coverage changes

@alpe alpe merged commit 661fd4b into main Jul 14, 2023
@alpe alpe deleted the system_test_reusable branch July 14, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants