Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Cosmos sdk 0.39 #146

Closed
wants to merge 6 commits into from
Closed

Tracking: Cosmos sdk 0.39 #146

wants to merge 6 commits into from

Conversation

ethanfrey
Copy link
Member

This tracks the long-lived branch that adds cosmos-sdk 0.39-master support.

wasmd:master will track the last stable release (0.38.x) and from that we can tag releases. This branch will live for adding IBC integrations until a cosmos-sdk 0.39.0 release is made, at which point it can be merged into master.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added relevant godoc comments.

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the Github PR explorer


For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #146 into master will decrease coverage by 36.87%.
The diff coverage is 10.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #146       +/-   ##
===========================================
- Coverage   67.90%   31.02%   -36.88%     
===========================================
  Files          23       22        -1     
  Lines        2053     3655     +1602     
===========================================
- Hits         1394     1134      -260     
- Misses        563     2426     +1863     
+ Partials       96       95        -1     
Impacted Files Coverage Δ
app/genesis.go 0.00% <0.00%> (ø)
x/wasm/internal/keeper/genesis.go 0.00% <0.00%> (-92.99%) ⬇️
x/wasm/internal/types/genesis.go 0.00% <ø> (-94.12%) ⬇️
x/wasm/internal/types/msg.go 44.33% <ø> (+3.56%) ⬆️
x/wasm/internal/types/types.go 0.00% <ø> (-32.41%) ⬇️
x/wasm/module.go 18.18% <0.00%> (+0.40%) ⬆️
x/wasm/internal/types/types.pb.go 0.53% <0.53%> (ø)
app/export.go 7.31% <60.00%> (ø)
x/wasm/handler.go 58.55% <78.57%> (+8.55%) ⬆️
lcd_test/helpers.go 74.63% <94.11%> (-0.37%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f62e8a...c5438b4. Read the comment docs.

@alpe alpe mentioned this pull request Jul 1, 2020
3 tasks
@alpe alpe force-pushed the cosmos-sdk-0.39 branch from 8cf06b9 to c5438b4 Compare July 3, 2020 12:20
@ethanfrey
Copy link
Member Author

This is a good reference for the IBC integration: https://docs.cosmos.network/master/ibc/custom.html

@ethanfrey
Copy link
Member Author

This was game of zone phase 3. More stable but outdated from #172

@ethanfrey ethanfrey closed this Jul 15, 2020
@alpe alpe deleted the cosmos-sdk-0.39 branch August 27, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants