Add system tests #1411

pinosu · 2023-05-18T14:02:28Z

No description provided.

alpe · 2023-05-19T07:44:13Z

tests/system/cli.go

@@ -263,7 +263,7 @@ func (c WasmdCli) QuerySmart(contractAddr, msg string, args ...string) string {
 }

 // QueryBalances queries all balances for an account. Returns json response
-// Example:`{"balances":[{"denom":"node0token","amount":"1000000000"},{"denom":"utgd","amount":"400000003"}],"pagination":{}}`
+// Example:`{"balances":[{"denom":"node0token","amount":"1000000000"},{"denom":"ustake","amount":"400000003"}],"pagination":{}}`


Good 👁️ ! Please use stake here and everywhere else instead of ustake. stake is the sdk.DefaultBondDenom` .

Suggested change

// Example:`{"balances":[{"denom":"node0token","amount":"1000000000"},{"denom":"ustake","amount":"400000003"}],"pagination":{}}`

// Example:`{"balances":[{"denom":"node0token","amount":"1000000000"},{"denom":"stake","amount":"400000003"}],"pagination":{}}`

alpe · 2023-05-19T07:44:22Z

tests/system/cli.go

@@ -284,23 +284,6 @@ func (c WasmdCli) QueryTotalSupply(denom string) int64 {
 	return gjson.Get(raw, "amount").Int()
 }

-// QueryValidator queries the validator for the given operator address. Returns json response


codecov · 2023-05-23T15:07:08Z

Codecov Report

Merging #1411 (ce088d9) into 1362_tests (ef25457) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

❗ Current head ce088d9 differs from pull request most recent head 2f5888c. Consider uploading reports for the commit 2f5888c to get more accurate results

@@              Coverage Diff               @@
##           1362_tests    #1411      +/-   ##
==============================================
- Coverage       60.14%   60.03%   -0.12%     
==============================================
  Files              60       61       +1     
  Lines            7557     7571      +14     
==============================================
  Hits             4545     4545              
- Misses           2676     2690      +14     
  Partials          336      336

Impacted Files	Coverage Δ
x/wasm/client/cli/new_tx.go	`0.00% <0.00%> (ø)`
x/wasm/client/cli/utils.go	`0.00% <0.00%> (ø)`

alpe

Good progress! 👏

alpe · 2023-05-24T12:04:54Z

.circleci/config.yml

@@ -95,6 +95,20 @@ jobs:
            - "profiles/*"
      - store_artifacts:
          path: /tmp/logs
+
+  test-system:


alpe · 2023-05-24T12:05:42Z

cmd/wasmd/root.go

@@ -31,6 +32,7 @@ import (
 	"github.com/spf13/cast"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
+	tmcmd "github.com/tendermint/tendermint/cmd/tendermint/commands"


⚠️ There should not be any dependency to tendermint. All is in CometBFT now.

alpe · 2023-05-24T12:08:03Z

cmd/wasmd/root.go

@@ -302,3 +305,26 @@ func appExport(

 	return wasmApp.ExportAppStateAndValidators(forZeroHeight, jailAllowedAddrs, modulesToExport)
 }
+
+// extendUnsafeResetAllCmd - also clear wasm dir
+func extendUnsafeResetAllCmd(rootCmd *cobra.Command) {


ah, you copied this over already. I had opened #1414 for this.

I was wondering if we want this here or in x/wasm/cli ?

alpe · 2023-05-24T12:08:25Z

go.mod

@@ -40,6 +40,7 @@ require (
 	github.com/cometbft/cometbft v0.37.1
 	github.com/cometbft/cometbft-db v0.7.0
 	github.com/spf13/viper v1.15.0
+	github.com/tendermint/tendermint v0.35.9


⚠️ This is CometBFT now

alpe · 2023-05-24T12:09:42Z

x/wasm/client/cli/new_tx.go

@@ -142,7 +142,7 @@ func UpdateInstantiateConfigCmd() *cobra.Command {
 			}

 			msg := types.MsgUpdateInstantiateConfig{
-				Sender:                   string(clientCtx.GetFromAddress()),
+				Sender:                   clientCtx.GetFromAddress().String(),


👍 Can you backport this for v0.40?

alpe · 2023-05-24T12:10:04Z

tests/system/basic_test.go

+
+	qResult = cli.CustomQuery("q", "wasm", "contract", newContractAddr)
+	actualAdmin := gjson.Get(qResult, "contract_info.admin").String()
+	assert.Equal(t, newAdmin, actualAdmin)


good tests!

alpe · 2023-05-24T12:12:09Z

tests/system/cli.go

@@ -256,14 +256,36 @@ func (c WasmdCli) WasmInstantiate(codeID int, initMsg string, args ...string) st
 	return addr
 }

+// Stake  delegates amount to given validator
+func (c WasmdCli) Stake(validatorAddr, amount string, args ...string) {


🤔 We should be careful to not blow up the CLI with too many features. If this is some common command then let's add it here to make the tests more readable otherwise it is better to have them in the test itself.

alpe · 2023-05-24T12:13:50Z

tests/system/cli_test.go

+	assert.Equal(t, sdk.NewCoins(sdk.NewCoin("stake", sdk.NewInt(200000002))), getGenesisBalance([]byte(raw), vest3Addr))
+}
+
+func TestStakeUnstake(t *testing.T) {


Let's move this to a new file. How about staking_tests.go ?

alpe · 2023-05-24T12:15:28Z

tests/system/cli_test.go

+	})
+}
+
+func TestVestingAccounts(t *testing.T) {


I guess this was a some work to port it. I would have skipped this test as it is testing the genesis generation only, which is not part of wasmd.

alpe · 2023-05-24T12:16:00Z

tests/system/fraud_test.go

+)
+
+func TestRecursiveMsgsExternalTrigger(t *testing.T) {
+	t.Skip()


I guess this is WIP ?

* Updates * Minor cleanup * Make tests pass

* Start system tests * Go mod tidy * Add system tests (#1411) * Add tests * Add test-system to CI * Fix path * Remove store artifact steps * Add small fixes * Add stake/unstake tests * Add unsafe-reset-all extention + system test * Replace ustake with stake * Add more tests + fix bug in cli * Fix comments and add multi contract system test * Updates and fixes to system tests (#1449) * Updates * Minor cleanup * Make tests pass --------- Co-authored-by: Alexander Peters <[email protected]> * Fix Makefile to return exit code for system tests (#1450) * Abort on error results --------- Co-authored-by: pinosu <[email protected]>

pinosu added 3 commits May 18, 2023 16:00

Add tests

7c98f53

Add test-system to CI

2d18a29

Fix path

ed6afa1

pinosu force-pushed the 1362_tests_update branch from af637c3 to ed6afa1 Compare May 18, 2023 19:50

Remove store artifact steps

6ef3f3f

alpe reviewed May 19, 2023

View reviewed changes

pinosu added 5 commits May 19, 2023 12:55

Add small fixes

73098b6

Add stake/unstake tests

d38264a

Add unsafe-reset-all extention + system test

5294100

Replace ustake with stake

7a36cdd

Add more tests + fix bug in cli

435a9f7

alpe reviewed May 24, 2023

View reviewed changes

pinosu and others added 2 commits May 25, 2023 16:46

Fix comments and add multi contract system test

ce088d9

Updates and fixes to system tests (#1449)

2f5888c

* Updates * Minor cleanup * Make tests pass

alpe marked this pull request as ready for review June 14, 2023 12:15

alpe merged commit 20c753d into 1362_tests Jun 14, 2023

alpe deleted the 1362_tests_update branch June 14, 2023 12:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add system tests #1411

Add system tests #1411

pinosu commented May 18, 2023

alpe May 19, 2023

alpe May 19, 2023

codecov bot commented May 23, 2023 •

edited

Loading

alpe left a comment

alpe May 24, 2023

alpe May 24, 2023

alpe May 24, 2023

alpe May 24, 2023

alpe May 24, 2023

alpe May 24, 2023

alpe May 24, 2023

alpe May 24, 2023

alpe May 24, 2023

alpe May 24, 2023

	// Example:`{"balances":[{"denom":"node0token","amount":"1000000000"},{"denom":"ustake","amount":"400000003"}],"pagination":{}}`
	// Example:`{"balances":[{"denom":"node0token","amount":"1000000000"},{"denom":"stake","amount":"400000003"}],"pagination":{}}`

Add system tests #1411

Add system tests #1411

Conversation

pinosu commented May 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented May 23, 2023 • edited Loading

Codecov Report

alpe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented May 23, 2023 •

edited

Loading