Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm store to import-export sims #1374

Merged
merged 1 commit into from
May 4, 2023
Merged

Add wasm store to import-export sims #1374

merged 1 commit into from
May 4, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented May 3, 2023

Resolves #1372

@alpe alpe requested a review from pinosu May 3, 2023 07:45
pinosu
pinosu approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit 4fe0380 into main May 4, 2023
@alpe alpe deleted the 1372_sims branch May 10, 2023 08:52
@alpe
Copy link
Contributor Author

alpe commented May 11, 2023 •
edited
Loading

This addresses only the SDK 47 branch. v0.32 has this set. No need to backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import export simulation test for x/wasm is missing
2 participants
@alpe @pinosu