Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build without cgo #1162

Closed
wants to merge 2 commits into from
Closed

Build without cgo #1162

wants to merge 2 commits into from

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jan 19, 2023

Resolves #1129

Credits and ❤️ go to the original author @jhernandezb 👏
Apache license

@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1162 (c16bad6) into wasmvm_1143rc1 (dc10fad) will decrease coverage by 0.03%.
The diff coverage is 48.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           wasmvm_1143rc1    #1162      +/-   ##
==================================================
- Coverage           57.46%   57.43%   -0.03%     
==================================================
  Files                  53       56       +3     
  Lines                7408     7408              
==================================================
- Hits                 4257     4255       -2     
- Misses               2853     2854       +1     
- Partials              298      299       +1     
Impacted Files Coverage Δ
x/wasm/client/cli/query.go 0.00% <ø> (ø)
x/wasm/client/cli/query_lib_version.go 0.00% <0.00%> (ø)
x/wasm/keeper/keeper.go 87.19% <ø> (-0.52%) ⬇️
x/wasm/libwasm_version.go 0.00% <0.00%> (ø)
x/wasm/module.go 41.22% <ø> (+3.32%) ⬆️
x/wasm/keeper/keeper_cgo.go 92.30% <92.30%> (ø)

@jhernandezb
Copy link
Contributor

I think this can be cleaned up, after I made the initial poc wasmvm.LibwasmvmVersion() now handles the cgo,no_cgo flags (by returning an error) I'll submit a new PR

@jhernandezb jhernandezb mentioned this pull request Jan 21, 2023
@alpe
Copy link
Contributor Author

alpe commented Jan 23, 2023

Obsolete by #1166

@alpe alpe closed this Jan 23, 2023
@alpe alpe deleted the build_without_cgo_1129 branch January 23, 2023 09:29
@alpe alpe mentioned this pull request Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants