Add proposal instantiate 2 #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1106 +/- ##
==========================================
- Coverage 59.95% 59.52% -0.43%
==========================================
Files 54 54
Lines 7406 7563 +157
==========================================
+ Hits 4440 4502 +62
- Misses 2641 2730 +89
- Partials 325 331 +6
|
alpe
reviewed
Nov 29, 2022
| @@ -21,4 +21,5 @@ var ProposalHandlers = []govclient.ProposalHandler{ | |||
| govclient.NewProposalHandler(cli.ProposalUnpinCodesCmd, rest.UnpinCodeProposalHandler), | |||
| govclient.NewProposalHandler(cli.ProposalUpdateInstantiateConfigCmd, rest.UpdateInstantiateConfigProposalHandler), | |||
| govclient.NewProposalHandler(cli.ProposalStoreAndInstantiateContractCmd, rest.EmptyRestHandler), | |||
| govclient.NewProposalHandler(cli.ProposalInstantiateContract2Cmd, rest.EmptyRestHandler), | |||
| } | ||
| } | ||
|
|
||
| _, data, err := k.Instantiate2(ctx, p.CodeID, runAsAddr, adminAddr, p.Msg, p.Label, p.Funds, p.Salt, p.FixMsg) |
| @@ -34,6 +35,7 @@ var DisableAllProposals []ProposalType | |||
| var EnableAllProposals = []ProposalType{ | |||
| ProposalTypeStoreCode, | |||
| ProposalTypeInstantiateContract, | |||
| ProposalTypeInstantiateContract2, | |||
| require.Len(t, em.Events()[2].Attributes, 1) | ||
| require.NotEmpty(t, em.Events()[2].Attributes[0]) | ||
| } | ||
|
|
x/wasm/types/authz.pb.go
Outdated
| @@ -5,25 +5,21 @@ package types | |||
|
|
|||
| import ( | |||
| fmt "fmt" | |||
| io "io" | |||
There was a problem hiding this comment.
Please run make format or make proto-all when you built from protobuf.
| }), | ||
| expErr: true, | ||
| }, | ||
| "init with empty salt": { |
| m(p) | ||
| } | ||
| return p | ||
| } |
Thank a lot for your reviews :3 |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1062