Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate REST endpoints #1070

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Deprecate REST endpoints #1070

merged 2 commits into from
Nov 9, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 1, 2022

See #782

Prepare to remove REST in the next version

@alpe alpe requested a review from pinosu November 1, 2022 15:19
@alpe
Copy link
Contributor Author

alpe commented Nov 8, 2022

The linter is failing on the deprecated package now. 😮‍💨 I will add some annotations

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Been waiting for this day

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #1070 (de6df17) into main (84e24d3) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
- Coverage   59.28%   59.19%   -0.09%     
==========================================
  Files          53       53              
  Lines        6722     6732      +10     
==========================================
  Hits         3985     3985              
- Misses       2442     2452      +10     
  Partials      295      295              
Impacted Files Coverage Δ
app/app.go 88.14% <ø> (ø)
x/wasm/keeper/legacy_querier.go 69.89% <ø> (ø)
x/wasm/module.go 37.90% <0.00%> (ø)
x/wasm/types/proposal.go 61.31% <0.00%> (-1.81%) ⬇️

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit 4fe2fbc into main Nov 9, 2022
@alpe alpe deleted the deprecate-rest branch November 9, 2022 07:58
NoahSaso pushed a commit to NoahSaso/wasmd that referenced this pull request Dec 2, 2022
* Deprecate REST support

* Add deprecation and nolint annotations
Magicloud pushed a commit to fpco/wasmd that referenced this pull request Jan 13, 2023
* Deprecate REST support

* Add deprecation and nolint annotations
conorpp pushed a commit to wormhole-foundation/wasmd that referenced this pull request Feb 1, 2023
* Deprecate REST support

* Add deprecation and nolint annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants