Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on (un)supported systems #107

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Add docs on (un)supported systems #107

merged 1 commit into from
Apr 17, 2020

Conversation

ethanfrey
Copy link
Member

Closes #105

Update README to explain no Windows or Alpine Linux support.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added relevant godoc comments.

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the Github PR explorer


For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ethanfrey
Copy link
Member Author

@yys does this solve your issue #105?

@ethanfrey ethanfrey merged commit 493a929 into master Apr 17, 2020
@ethanfrey ethanfrey deleted the no-alpine-support branch April 17, 2020 18:11
loloicci pushed a commit to loloicci/wasmd that referenced this pull request Feb 8, 2024
* chore: Added comment about ordering of addresses

* chore: add this pr to change.log

* fix: fix singular

* fix: fix pr title

* fix: fix singular

* fix: Correct uppercase letters to lowercase letters

* fix: Correct to specify the type of elements in List of addresses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make build-linux failed
1 participant