Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version go to 1.19 #1044

Merged
merged 6 commits into from
Nov 18, 2022
Merged

Conversation

GNaD13
Copy link
Contributor

@GNaD13 GNaD13 commented Oct 9, 2022

Close #1041

@GNaD13 GNaD13 requested a review from alpe as a code owner October 9, 2022 15:33
@alpe
Copy link
Contributor

alpe commented Oct 10, 2022

Thanks for the PR! This was quicker than planned. Bumping to 1.19 means chains importing the module would also have to upgrade.
For Context: cosmos/cosmos-sdk#13373 (comment)

@GNaD13
Copy link
Contributor Author

GNaD13 commented Oct 16, 2022

Thanks for the PR! This was quicker than planned. Bumping to 1.19 means chains importing the module would also have to upgrade. For Context: cosmos/cosmos-sdk#13373 (comment)

Got it. Thanks for your review!!

@GNaD13 GNaD13 closed this Nov 7, 2022
@GNaD13 GNaD13 deleted the dang/bump-go-minimum1.19 branch November 7, 2022 15:54
@alpe
Copy link
Contributor

alpe commented Nov 11, 2022

Let's do the upgrade in v0.31 which is getting closer

@alpe
Copy link
Contributor

alpe commented Nov 17, 2022

@GNaD13 can you open the PR again, please? We want this for v0.30 after the recent issue on a mainnet

CHANGELOG.md Outdated
@@ -11,7 +11,7 @@
- Allow AccessConfig to use a list of addresses instead of just a single address [\#945](https://github.com/CosmWasm/wasmd/issues/945)
- Make contract addresses predictable \("deterministic"\) [\#942](https://github.com/CosmWasm/wasmd/issues/942)
- Add query for the total supply of a coin [\#903](https://github.com/CosmWasm/wasmd/pull/903) ([larry0x](https://github.com/larry0x))
- Upgrade go to v1.18 [\#866]https://github.com/CosmWasm/wasmd/pull/866/) ([faddat](https://github.com/faddat))
- Upgrade go to v1.19 [\#866]https://github.com/CosmWasm/wasmd/pull/866/) ([faddat](https://github.com/faddat))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new line on top

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have resolved this. Tysm :3

@@ -13,7 +13,7 @@ This code was forked from the `cosmos/gaia` repository as a basis and then we ad
many gaia-specific files. However, the `wasmd` binary should function just like `gaiad` except for the
addition of the `x/wasm` module.

**Note**: Requires [Go 1.18+](https://golang.org/dl/)
**Note**: Requires [Go 1.19+](https://golang.org/dl/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,6 +1,6 @@
module github.com/CosmWasm/wasmd

go 1.18
go 1.19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GNaD13
Copy link
Contributor Author

GNaD13 commented Nov 17, 2022

@GNaD13 can you open the PR again, please? We want this for v0.30 after the recent issue on a mainnet

Yeah, I got it :3

@GNaD13 GNaD13 restored the dang/bump-go-minimum1.19 branch November 17, 2022 18:08
@GNaD13 GNaD13 reopened this Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #1044 (d4b3868) into main (81a5154) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
- Coverage   59.82%   59.79%   -0.03%     
==========================================
  Files          54       54              
  Lines        7273     7273              
==========================================
- Hits         4351     4349       -2     
- Misses       2611     2612       +1     
- Partials      311      312       +1     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 87.40% <0.00%> (-0.32%) ⬇️

@alpe alpe merged commit fc476aa into CosmWasm:main Nov 18, 2022
@alpe
Copy link
Contributor

alpe commented Nov 18, 2022

Thanks a lot! 👍

orkunkl pushed a commit that referenced this pull request Nov 21, 2022
* bump go 1.19

* add change log

* correct change log
alpe added a commit that referenced this pull request Nov 22, 2022
…proposal message (#1072)

* Provide source, builder and codehash information in store code proposal message

* Make linter happy

* Update x/wasm/simulation/proposals.go

Co-authored-by: Alexander Peters <[email protected]>

* Update x/wasm/client/cli/gov_tx.go

* Update x/wasm/client/cli/gov_tx.go

* Bump github.com/cosmos/gogoproto from 1.4.2 to 1.4.3

Bumps [github.com/cosmos/gogoproto](https://github.com/cosmos/gogoproto) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/cosmos/gogoproto/releases)
- [Changelog](https://github.com/cosmos/gogoproto/blob/main/CHANGELOG.md)
- [Commits](cosmos/gogoproto@v1.4.2...v1.4.3)

---
updated-dependencies:
- dependency-name: github.com/cosmos/gogoproto
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update authz grant examples

* Enable larger wasm bytecode upload for gov proposals (#1095)

* Enable larger wasm bytecode upload for gov proposals

* Set max proposal wasm code size to 3MB

* Bump SDK to v0.45.11

* Fix license head

* Fix README header

* Bump version go to 1.19 (#1044)

* bump go 1.19

* add change log

* correct change log

* Provide source, builder and codehash information in store code proposal message

* Implement source, builder, code_info for StoreAndInstantiateProposal

* Apply review recommendations

* Make linter happy

* Fix tests

* Formatting only

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Alexander Peters <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Giancarlos Salas <[email protected]>
Co-authored-by: pinosu <[email protected]>
Co-authored-by: GNaD13 <[email protected]>
NoahSaso pushed a commit to NoahSaso/wasmd that referenced this pull request Dec 2, 2022
* bump go 1.19

* add change log

* correct change log
NoahSaso pushed a commit to NoahSaso/wasmd that referenced this pull request Dec 2, 2022
…proposal message (CosmWasm#1072)

* Provide source, builder and codehash information in store code proposal message

* Make linter happy

* Update x/wasm/simulation/proposals.go

Co-authored-by: Alexander Peters <[email protected]>

* Update x/wasm/client/cli/gov_tx.go

* Update x/wasm/client/cli/gov_tx.go

* Bump github.com/cosmos/gogoproto from 1.4.2 to 1.4.3

Bumps [github.com/cosmos/gogoproto](https://github.com/cosmos/gogoproto) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/cosmos/gogoproto/releases)
- [Changelog](https://github.com/cosmos/gogoproto/blob/main/CHANGELOG.md)
- [Commits](cosmos/gogoproto@v1.4.2...v1.4.3)

---
updated-dependencies:
- dependency-name: github.com/cosmos/gogoproto
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update authz grant examples

* Enable larger wasm bytecode upload for gov proposals (CosmWasm#1095)

* Enable larger wasm bytecode upload for gov proposals

* Set max proposal wasm code size to 3MB

* Bump SDK to v0.45.11

* Fix license head

* Fix README header

* Bump version go to 1.19 (CosmWasm#1044)

* bump go 1.19

* add change log

* correct change log

* Provide source, builder and codehash information in store code proposal message

* Implement source, builder, code_info for StoreAndInstantiateProposal

* Apply review recommendations

* Make linter happy

* Fix tests

* Formatting only

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Alexander Peters <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Giancarlos Salas <[email protected]>
Co-authored-by: pinosu <[email protected]>
Co-authored-by: GNaD13 <[email protected]>
Magicloud pushed a commit to fpco/wasmd that referenced this pull request Jan 13, 2023
* bump go 1.19

* add change log

* correct change log
Magicloud pushed a commit to fpco/wasmd that referenced this pull request Jan 13, 2023
…proposal message (CosmWasm#1072)

* Provide source, builder and codehash information in store code proposal message

* Make linter happy

* Update x/wasm/simulation/proposals.go

Co-authored-by: Alexander Peters <[email protected]>

* Update x/wasm/client/cli/gov_tx.go

* Update x/wasm/client/cli/gov_tx.go

* Bump github.com/cosmos/gogoproto from 1.4.2 to 1.4.3

Bumps [github.com/cosmos/gogoproto](https://github.com/cosmos/gogoproto) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/cosmos/gogoproto/releases)
- [Changelog](https://github.com/cosmos/gogoproto/blob/main/CHANGELOG.md)
- [Commits](cosmos/gogoproto@v1.4.2...v1.4.3)

---
updated-dependencies:
- dependency-name: github.com/cosmos/gogoproto
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update authz grant examples

* Enable larger wasm bytecode upload for gov proposals (CosmWasm#1095)

* Enable larger wasm bytecode upload for gov proposals

* Set max proposal wasm code size to 3MB

* Bump SDK to v0.45.11

* Fix license head

* Fix README header

* Bump version go to 1.19 (CosmWasm#1044)

* bump go 1.19

* add change log

* correct change log

* Provide source, builder and codehash information in store code proposal message

* Implement source, builder, code_info for StoreAndInstantiateProposal

* Apply review recommendations

* Make linter happy

* Fix tests

* Formatting only

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Alexander Peters <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Giancarlos Salas <[email protected]>
Co-authored-by: pinosu <[email protected]>
Co-authored-by: GNaD13 <[email protected]>
conorpp pushed a commit to wormhole-foundation/wasmd that referenced this pull request Feb 1, 2023
* bump go 1.19

* add change log

* correct change log
conorpp pushed a commit to wormhole-foundation/wasmd that referenced this pull request Feb 1, 2023
…proposal message (CosmWasm#1072)

* Provide source, builder and codehash information in store code proposal message

* Make linter happy

* Update x/wasm/simulation/proposals.go

Co-authored-by: Alexander Peters <[email protected]>

* Update x/wasm/client/cli/gov_tx.go

* Update x/wasm/client/cli/gov_tx.go

* Bump github.com/cosmos/gogoproto from 1.4.2 to 1.4.3

Bumps [github.com/cosmos/gogoproto](https://github.com/cosmos/gogoproto) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/cosmos/gogoproto/releases)
- [Changelog](https://github.com/cosmos/gogoproto/blob/main/CHANGELOG.md)
- [Commits](cosmos/gogoproto@v1.4.2...v1.4.3)

---
updated-dependencies:
- dependency-name: github.com/cosmos/gogoproto
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update authz grant examples

* Enable larger wasm bytecode upload for gov proposals (CosmWasm#1095)

* Enable larger wasm bytecode upload for gov proposals

* Set max proposal wasm code size to 3MB

* Bump SDK to v0.45.11

* Fix license head

* Fix README header

* Bump version go to 1.19 (CosmWasm#1044)

* bump go 1.19

* add change log

* correct change log

* Provide source, builder and codehash information in store code proposal message

* Implement source, builder, code_info for StoreAndInstantiateProposal

* Apply review recommendations

* Make linter happy

* Fix tests

* Formatting only

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Alexander Peters <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Giancarlos Salas <[email protected]>
Co-authored-by: pinosu <[email protected]>
Co-authored-by: GNaD13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Go minimum to 1.19
2 participants