Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a data field to InitResponse #744

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Add a data field to InitResponse #744

merged 1 commit into from
Jan 25, 2021

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Jan 23, 2021 •
edited
Loading

This increases consistency between InitResponse, MigrateResponse and HandleResponse. The corresponding wasmd change is in CosmWasm/wasmd#385.

Note: conflicts with #740, so one must be updated after the other is merged.

@webmaster128 webmaster128 mentioned this pull request Jan 23, 2021
Merged
ethanfrey
ethanfrey approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I'd be happy to re-unify these response types more.

@ethanfrey ethanfrey merged commit 7a86458 into main Jan 25, 2021
@ethanfrey ethanfrey deleted the init-data branch January 25, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmaster128 @ethanfrey