Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement add for Uint* more consistently #2092

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Apr 9, 2024

  • Streamline implementation for references by using forward_ref_binop!
  • use better error panic message for overflows for Uint64/Uint512 (before "called Option::unwrap() on a None value")

Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webmaster128 webmaster128 merged commit 31c34b3 into main Apr 9, 2024
29 checks passed
@webmaster128 webmaster128 deleted the uint-add-impl branch April 9, 2024 15:06
@webmaster128
Copy link
Member Author

@mergify backport release/2.0 release/1.5 release/1.4

Copy link
Contributor

mergify bot commented Apr 9, 2024

backport release/2.0 release/1.5 release/1.4

✅ Backports have been created

webmaster128 added a commit that referenced this pull request Apr 9, 2024
Implement add for Uint* more consistently (backport #2092)
webmaster128 added a commit that referenced this pull request Apr 9, 2024
Implement add for Uint* more consistently (backport #2092)
webmaster128 added a commit that referenced this pull request Apr 9, 2024
Implement add for Uint* more consistently (backport #2092)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants