Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove print_debug flag #1953

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Remove print_debug flag #1953

merged 3 commits into from
Nov 20, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1841

webmaster128
webmaster128 approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏇 cool – just the CHANGELOG

packages/vm/src/instance.rs
}
e
});
let fe = FunctionEnv::new(&mut store, Environment::new(backend.api, gas_limit));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A caller can do this now quite easily and powerful:

cosmwasm/packages/vm/examples/memory.rs

Lines 139 to 143 in 385efdb

instance.set_debug_handler(|_msg, info| {
let _t = now_rfc3339();
let _gas = info.gas_remaining;
//eprintln!("[{t}]: {msg} (gas remaining: {gas})");
});

@chipshort chipshort merged commit 4caa9f0 into main Nov 20, 2023
22 of 27 checks passed
@chipshort chipshort deleted the 1841-remove-debug branch November 20, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove print_debug flag from cosmwasm-vm
2 participants
@chipshort @webmaster128