Fixed clippy warnings and spelling

[DariuszDepta]

No description provided.

[chipshort]

Looks good, I just want to propose two changes

[chipshort]

LGTM

[webmaster128]

How did you get those clippy warnings? Why does our CI not catch them? Is it due to new rules?

[DariuszDepta]

My scenario is usually as follows:

Checking installed toolchains, make sure nighty is there

$ rustup show

Update Rust to newest version

$ rustup update

Run clippy

$ cargo +nightly clippy [--workspace] [--features] --all-targets

This way clippy is newest, and checks also test cases and benchmarks.

The risk is, that after fixing clippy warnings in newest Rust version, the older version may not compile the code.
After applying the changes, building the project using older compiler must be done. And this is done on CI.

So I have catched these warnings because of new rules I guess in newest nightly version of Rust compiler.

[webmaster128]

I see, thanks. The thing I wanted to point out is that we should ensure the upper version from

cosmwasm/.circleci/config.yml

Line 75 in 6d3f9b0

rust-version: ["1.67.0", "1.72.0"]

is bumped along with clippy fixes. This ensure the codebase remains compliant with the latest stable Rust. But then it seems like you fixed rules that are not in stable yet in this PR.

[DariuszDepta]

In this PR there are no unstable features fixes, the code compiles with Rust version defined in CI.
In the future I will stick to clippy warnings reported by the last stable Rust version as defined in CI:

  clippy:
    parameters:
      rust-version:
        type: string
    docker:
      # In this job we use the latest Rust stable in order to check against the
      # most recent code style recommendations.
      - image: rust:<< parameters.rust-version >>

Thanks for pointing out, such procedure could accidentally lead to compilation problems. Thanks again!