Signed integers #1718
Merged
Signed integers #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Simon Warta <[email protected]>
chipshort
force-pushed
the
chipshort/signed-math
branch
from
2c7c97c
to
8d89684
Compare
|
I added the missing signed ints and rebased on 1.3 |
maurolacy
reviewed
Jun 30, 2023
| /// This operation will panic if `rhs` is zero. | ||
| #[inline] | ||
| fn rem(self, rhs: Self) -> Self { | ||
| Self(self.0.rem(rhs.0)) |
There was a problem hiding this comment.
Nit: Rely on checked_rem for consistency?
There was a problem hiding this comment.
I tried to keep it consistent with the unsigned ones (they have the same implementation for rem).
Actually, I think it might be better to change the ones using self.0.checked_* to use either self.0.*, a self.checked_* call or an explicit message using .expect. That would give more helpful panic messages.
But I think we can do that later.
| } | ||
| forward_ref_op_assign!(impl ShlAssign, shl_assign for Int64, u32); | ||
|
|
||
| impl Serialize for Int64 { |
There was a problem hiding this comment.
Perhaps not worth it, but, move all the serialisations to a int_se module?
| } | ||
| } | ||
|
|
||
| impl<'de> Deserialize<'de> for Int64 { |
There was a problem hiding this comment.
Same here, own int_de module? Not sure about this, just saying.
| Self: Add<A, Output = Self>, | ||
| { | ||
| fn sum<I: Iterator<Item = A>>(iter: I) -> Self { | ||
| iter.fold(Self::zero(), Add::add) |
hashedone
approved these changes
Jun 30, 2023
maurolacy
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1710
bnumcratebnum)