Debug impl for Decimal/Decimal256 uses decimal output #1600
Conversation
|
Good idea, thanks. Could you do the same change for Decimal and add tests for that (see e.g. |
|
Totally, complete oversight on my part about |
webmaster128
changed the title
packages/std/src/math/decimal.rs
Outdated
| @@ -457,6 +457,12 @@ impl fmt::Display for Decimal { | |||
| } | |||
| } | |||
|
|
|||
| impl fmt::Debug for Decimal { | |||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | |||
| write!(f, "{}", self) | |||
There was a problem hiding this comment.
Okay, now this shows the value but the Debug implementation should also include the type, right? Otherwise Decimal and Decimal256 cannot be differentiated. Also https://doc.rust-lang.org/std/fmt/trait.Debug.html suggests including the type name.
What about this?
| write!(f, "{}", self) | |
| write!(f, "Decimal({})", self) |
There was a problem hiding this comment.
That makes sense, and I'd considered going in that direction originally. I didn't realize the Debug docs recommend including the type name, thank you for pointing that out! I've updated the PR with that change.
|
Rebased and merged as part of #1602. Thank you! |
No description provided.