Parse contract address from instantiate event, not message event #1046
Conversation
| @@ -355,9 +355,7 @@ mod tests { | |||
| } | |||
|
|
|||
| fn fake_events(reflect_addr: &str) -> Vec<Event> { | |||
| let event = Event::new("message").add_attributes(vec
There was a problem hiding this comment.
The events changed. We no longer emit message events (or no longer expose those to the contracts), However, we have instantiate/execute/migrate events with a subset of the event types.
I wrote this to document the new behavior, which we need to model/mock: https://github.com/CosmWasm/wasmd/blob/master/EVENTS.md (and we are updating wasmd to it right now)
|
Thanks. I also rebuilt the vm test contract. I would merge and tag v0.16.0+contracts to get the CI to rebuild a set of wasm contracts, but never publish that (or use that as a crate version). It is Simon's technique to do a contract-only release when we need to patch for wasmd testing (these contracts are just for testing purposes and not released as crates) |
Sure, sounds good to me. |
|
Done |
To elaborate here: we use the semver build metadata for tags that do not affect the code in |
Fixes an issue that occurred when we updated the events handling in wasmd.
Notably CosmWasm/wasmd#586
(This is also a good argument that we stabilise the events before a 1.0 release)