Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support 1.8.8 and 1.8 #146

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

Tartilla-TAIGO
Copy link
Contributor

@Tartilla-TAIGO Tartilla-TAIGO commented May 9, 2024

What does the pull request do
Add support legacy installer for 1.8.8 and 1.78 Forge


PR-Codex overview

The focus of this PR is to refactor the logic for generating Forge installation strings based on Minecraft version.

Detailed summary

  • Refactored Forge installation string generation logic
  • Added a switch statement to handle different Minecraft version scenarios
  • Improved readability and maintainability of the code

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

sonarqubecloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@laolarou726 laolarou726 self-requested a review May 9, 2024 10:05
@laolarou726 laolarou726 self-assigned this May 9, 2024
@laolarou726 laolarou726 added the 新功能/改进 enhancement 增加新功能 New feature or request label May 9, 2024
@laolarou726 laolarou726 merged commit 85432fc into Corona-Studio:master May 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
新功能/改进 enhancement 增加新功能 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants