tensorflow model: fix TensorflowModelMixin usage #201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Following the discussions around MRO, I noticed an issue with regards to the way we use the
TensorflowModelMixin
.Before: its initialization is never called, hence the
ImportError
iftensorflow
is missing is never raised and a cryptic error is raised later onAfter this PR: its initialization is called, and directly raises the
ImportError
iftensorflow
is missing.Thanks for your review