Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow call to build workflow #17

Closed

Conversation

ryno-swart-corigine
Copy link
Contributor

@ryno-swart-corigine ryno-swart-corigine commented Mar 10, 2024

Allow the build workflow to be called.

While at it, also update the checkout and cache actions to v4 Edit: removed this, because it seems the docker containers do not have Node20 installed.

@ryno-swart-corigine ryno-swart-corigine changed the title git logWip cicd 2678 private build workflow Add workflow call to build workflow Mar 10, 2024
Allow the build workflow to be called.

This enables calling the build workflow from internal/private
repositories.

Signed-off-by: Ryno Swart <[email protected]>
Copy link
Collaborator

@louis-peens louis-peens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: removed this, because it seems the docker containers do not have Node20 installed.

Hehe, went through the same exercise the other day - CentOS7 does indeed not seem to support Node20. I'm actually watching two github issue for this: actions/runner#2906
actions/runner#3128

As mentioned, I highly suspect this would be using some of our runner minutes, I'm hoping that Charles would have a view where he can see this.

@ryno-swart-corigine
Copy link
Contributor Author

The intended purpose of this patch was to execute builds internally without occupying self-hosted runners or accruing billable time on the company account. This patch does not meet the above requirement, although it does make it trivial to run builds internally, so it might still be useful in the future.
Closing for now.

@louis-peens louis-peens deleted the wip-CICD-2678-private-build-workflow branch May 3, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants