Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated fkirc/skip-duplicate-actions to v5.3.0 #114

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

secureshellprotocol
Copy link
Member

fkirc/skip-duplicate-actions#292
updating "skip-duplicate-actions" in pre_job workflow
v4 of this workflow action uses deprecated commands, v5.2.0 fixed this. opted to just add latest though

@dmezh
Copy link
Member

dmezh commented Feb 5, 2023

Nit: git commits should be imperative - like update skip-duplicate-actions rather than updated skip-duplicate-actions. From git's git repo:

[[imperative-mood]]
Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behavior.  Try to make sure your explanation can be understood
without external resources. Instead of giving a URL to a mailing list
archive, summarize the relevant points of the discussion.

@secureshellprotocol secureshellprotocol merged commit 38c72c4 into dev Feb 5, 2023
@secureshellprotocol secureshellprotocol deleted the user/secureshellprotocol/prejob-v2 branch February 5, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants