Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: meter widget not using limits defined in editor when pv missing display limits #2274

Merged
merged 1 commit into from
May 25, 2022

Conversation

cjenkscybercom
Copy link
Collaborator

@cjenkscybercom cjenkscybercom commented May 25, 2022

To replicate the issue / test first run:

softIocPVA -d CSSTUDIO-1339.db

Then, open CSSTUDIO-1339.bob in CSStudio

Archive.zip

@shroffk shroffk requested a review from kasemir May 25, 2022 12:18
@shroffk
Copy link
Member

shroffk commented May 25, 2022

Looks like a reasonable check

@kasemir
Copy link
Collaborator

kasemir commented May 25, 2022

Looks good.
Kunal, note that there's still the related VType range issue epics-base/epicsCoreJava#56:
We can't have just a minimum display limit without a maximu,, or just a HIGH warning without a LOW.
On the record, you can set just HIGH, and LOW is then reported as NaN. But the VType wants to create a LOW..HIGH Range where both ends are valid.

@kasemir kasemir merged commit d91ba90 into master May 25, 2022
@kasemir kasemir deleted the csstudio-1339-jenks branch May 25, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants