Downloads refactor - use a common downloader across all APIs #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blahah
changed the title
|
@tarrow how close is this to being ready to review? |
tarrow
force-pushed
the
updateurldownloader
branch
from
6328361 to
d976126
Compare
|
Any thoughts on this yet? I think the ability to download an arbitrary number of papers without it timing out is quite a good thing to get working. Please let me know if I can improve any bits of it :) |
|
All looks good @tarrow! We can refine later, but for now let's just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code to put common downloader code all together.
Downloads are still async but now have 10 workers rather than as many workers as there are downloads.
Also fixed an area where I could see a possible bug occuring (but didn't see in the wild) where the ids for arxiv files were found independent of the pdf and supplementary files urls which means that if a pdf (or supp files) url was missing then paper would be put in a folder with the wrong id.
We handle retries within each download not in bulk at the end. This could be adapted if we want.