Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pull_request_template and add "inline documentation" conventions to README #83

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

ttarczynski
Copy link
Contributor

@ttarczynski ttarczynski commented Aug 2, 2021

It's related to: #58

Changes/added features:

  • Add a successful ./run.sh to PR checklist (in .github/pull_request_template.md)
  • Add "inline documentation" conventions (to README.md)

The following short checklist should be used to make sure your PR is of good quality, and can be merged easily:

Reviewers:
@ianmiell
@ttarczynski
@sanyer

"inline documentation" conventions
@ttarczynski ttarczynski requested a review from teszes August 2, 2021 14:23
@ttarczynski ttarczynski changed the title Improve pull_request_template and doccument Improve pull_request_template and add "inline documentation" conventions to README Aug 2, 2021
@ttarczynski ttarczynski merged commit 024a3ac into main Aug 3, 2021
@ttarczynski ttarczynski deleted the project_conventions_documentation branch August 3, 2021 15:11
@ttarczynski ttarczynski added this to the 0.1 Project infrastructure milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants