Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal bin/apply* bin/destroy* scripts #53

Merged
merged 11 commits into from
Jun 16, 2021

Conversation

ttarczynski
Copy link
Contributor

@ttarczynski ttarczynski commented Jun 14, 2021

Goals:

  • with more and more scripts it makes sense to generalize them
  • reduce bash code duplication

@ttarczynski
Copy link
Contributor Author

I have it ready for kubernetes provider.
Todo: use generic scripts for all other provders.

@ttarczynski ttarczynski changed the title WIP: universal bin/apply* bin/destroy* scripts Universal bin/apply* bin/destroy* scripts Jun 15, 2021
@ttarczynski ttarczynski mentioned this pull request Jun 15, 2021
7 tasks
@ttarczynski ttarczynski marked this pull request as ready for review June 15, 2021 07:01
@ttarczynski
Copy link
Contributor Author

Done:

  • all examples use uniform bin/apply.sh, bin/destroy.sh scripts

@sanyer
Copy link
Contributor

sanyer commented Jun 15, 2021

oh, it's in your fork
I was looking for a branch and almost reinstalled VSCode :-D

@sanyer
Copy link
Contributor

sanyer commented Jun 15, 2021

Looks good, I don't have any questions

@sanyer sanyer self-requested a review June 15, 2021 13:23
Copy link
Contributor

@sanyer sanyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.
A really good first step in optimizing the scripts 👍🏻

@sanyer
Copy link
Contributor

sanyer commented Jun 15, 2021

As the next improvements, we can look into the shared scripts and into apply and destroy scripts in each example. We might as well build some simple cli tool for this.

@ttarczynski
Copy link
Contributor Author

I've just merged this into integration now.
To double check the CI.

@ttarczynski
Copy link
Contributor Author

I've forced a complete test run on integration (see this commit). Was all OK, so merging this to main.

@ttarczynski ttarczynski merged commit 7b6f63e into ContainerSolutions:main Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants