Fixed bin/check_scripts.sh to display correct dir if a check has failed #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link related issues:
Changes/added features:
bin/check_scripts.sh. When this check has failed it wasn't listing the correct directory. Plus the error messages were misleading.Bug fixed:
bin/check_scripts.shas could be seen in this GitHub actions run: https://github.com/ContainerSolutions/terraform-examples/runs/4808091030?check_suite_focus=trueI've tested it manually on local, and also in our CI:
The following short checklist should be used to make sure your PR is of good quality, and can be merged easily:
./run.shworks correctly for all new examplesReviewers:
@ianmiell
@ttarczynski
@sanyer
@teszes
@choilmto
@rodrigorras
@vmhlotsh1