-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decision Proposal 282 - Urgent FAPI 1.0 Phase 3 migration changes #282
Comments
Clarification for decision write-up please - Issue 547 point 13 seems to indicate id_token encryption is not allowed for ACF. My understanding is that DCR client metadata does not allow the ADR to differentiate id_token encryption for each flow, therefore the standard must support id_token encryption for ACF where the ADR is registered for both Hybrid Flow and ACF. Can you clarify please if id_token encryption is OPTIONAL or NOT ALLOWED for ADRs who register solely for ACF? |
We request the below minor changes in order to allow for the current Data Holder implementation timeframes: JARM Response Signing This should be a ‘And/Or’ for Data Holders. ID Token Encryption This is in order to align to existing implementations and avoid rework for data holders and data recipients who have implemented the existing model. If there is a need to change these to conditional then we request a future dated obligation (beyond the April 2023 timeline). |
The Data Standards Chair has now approved this decision. The decision record can be found in the original post. |
Hi @tinagroark
ID Token encryption only applies to the OIDC Hybrid Flow. If the ADR is registered for both Hybrid Flow and Authorization Code Flow, the ID Token encryption algorithms shall apply to Hybrid Flow but be ignored for ACF. |
Hi @anzbankau,
The final decision has been changed to require Data holders to support only one of the chosen algorithms ('OR').
The final decision has included a qualifying statement to require these values for Hybrid Flow. They should be ignored by the Data Holder for Authorization Code Flow. |
Thanks for the updates. However, to note – our intention on the "id_token_encrypted_response_alg" and "id_token_encrypted_response_enc" being required also implied that these would be used for both Hybrid Flow and ACF. So, our ask is that these fields remain required, and that token encryption is still allowable for both Hybrid flow and ACF. Our implementation (and possibly others) will take the values from these fields and apply it regardless of whether Hybrid flow or ACF is used. |
If the ADR is registered for both Hybrid Flow and ACF, the ID token encryption attributes become mandatory in the DCR JWT sent to DH for registration. This will encrypt the id_token in both the flow as the id_token encryption values will be added under the registered client in DH. |
Agree that alternatively to our suggestion above, if the ADR was restricted to be registered for only one type of flow the issue would be resolved for us. |
Hi, I have few questions regarding the following part:
|
Westpac's Implementation approachThe purpose of this post is to allow the community to review Westpac’s implementation view for FAPI 1.0 Ph. 3 and provide their alignment to the solution. We are not recommending any changes or feedback to the standards by this post. In line with the recently revised v1.21 CDS for FAPI 1.0, Westpac will be upgrading its DH implementation to enable support for both Authorisation Code flow (ACF) from 14-Apr-23 & continue supporting OIDC Hybrid flow (OHF) till 10-Jul-23. Westpac DH implementation adheres to DP 282 ( Decision 282 - JARM and Authorization Code Flow For FAPI 1.0 Phase 3 Obligations - final.pdf ), FAPI 1 JARM standards ( openid / fapi / oauth-v2-jarm.md — Bitbucket ) & changes proposed as per CDR maintenance issue #576 ( Change id token encryption documentation to allow for use in Hybrid flow and ACF · Issue #576 · ConsumerDataStandardsAustralia/standards-maintenance · GitHub ) to facilitate the transitionary period where OIDC Hybrid Flow is still supported.
Authorisation Code flow ( ACF )
OIDC Hybrid flow ( OHF )
|
…ce/592 Standards Maintenance Issue #592
Decision Record
The Data Standards Chair approved this decision on 16th December 2022. The decision record is attached:
Decision 282 - JARM and Authorization Code Flow For FAPI 1.0 Phase 3 Obligations - final.pdf
09/12/2022:
This issue is a placeholder for the decision in relation to two urgent change requests that were consulted on in Maintenance Iteration 13.
The details of the change proposals can be found here:
The text was updated successfully, but these errors were encountered: