-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance Iteration 20 Holistic Feedback #647
Comments
In the section Data Recipients calling Data Holders, the first bullet point appears to be redundant and could be removed - the second point seems to state the same requirement more clearly (change highlighted here). There is a typo in the first sentence of the third point. Make the following change: - authorisation_code
+ authorization_code |
Documentation updates: |
In the Security Profile section > Data Recipients calling Data Holders, the requirements in the first two bullet points appear to be repeated. The highlighted text in the statements is identical: The proposal is to remove the first bullet point:
|
There appears to be a copy/paste error in the description of the tariffUType field in the EnergyPlanSolarFeedInTariffV3 schema: - The type of the payer
+ Reference to the applicable tariff structure. |
The "Reference to the applicable [type] structure." convention could be applied to all ...UType field descriptions for consistency and clarity of interpretation. The following sample shows the current variation across schemas:
|
In the Common Field Types section, change the value in the Valid Examples column for the URIString type: - "http://www.google.com"
+ "https://www.example.com" |
A documentation change has also been posted on the Staging repository: #413 - Merge Change Log and Archives sections |
This issue has been staged for review: ConsumerDataStandardsAustralia/standards-staging@59db12d |
This issue has been staged for review: ConsumerDataStandardsAustralia/standards-staging@0f6604b |
This issue has been staged for review: ConsumerDataStandardsAustralia/standards-staging@53c9ace |
This issue has been staged for review: ConsumerDataStandardsAustralia/standards-staging@9c0ae78 |
These have been staged - |
This will be deferred to a later MI - #434 - Apply consistent UType field descriptions |
This has been staged - Merged the Change Log and Archives sections |
* Created 1.32.0 branch base * Updated to newer openapi-generator-cli Added new jar and removed older jars * Merged the Change Log and Archives sections Addresses: ConsumerDataStandardsAustralia/standards-staging#413 * Retaining original anchors * Fixed spelling mistake for authorization_code reference. Addresses issue comment ConsumerDataStandardsAustralia/standards-maintenance#647 (comment) * Removed redundant statement regarding client ID. Addresses issue ConsumerDataStandardsAustralia/standards-maintenance#647 (comment) * Corrected field description for tariffUType. Addresses issue ConsumerDataStandardsAustralia/standards-maintenance#647 (comment) * Updated URIString example to use HTTPS scheme rather than HTTP. Addresses issue ConsumerDataStandardsAustralia/standards-maintenance#647 (comment) * Update details in Common Field Types section Addresses: ConsumerDataStandardsAustralia/standards-maintenance#641 * Clarified the format of adjustment rate values Addresses: ConsumerDataStandardsAustralia/standards-maintenance#641 * Fixed typos Addresses: ConsumerDataStandardsAustralia/standards-staging#411 * Endpoint as one word Addresses: ConsumerDataStandardsAustralia/standards-staging#411 (comment) and ConsumerDataStandardsAustralia/standards-maintenance#527 (comment) * Corrected required properties Addresses: ConsumerDataStandardsAustralia/standards-staging#417 * Add version delta comment and removed line breaks * #418 - Add CX guidelines link to footer Addresses: ConsumerDataStandardsAustralia/standards-staging#418 * Update Common and Admin APIs descriptions * Staging #419 - Update field name styling Addresses: ConsumerDataStandardsAustralia/standards-staging#419 * Update description of Product Categories section Addresses: ConsumerDataStandardsAustralia/standards-staging#411 (comment) * Staging #426 - Corrected OAS, moved files Addresses: ConsumerDataStandardsAustralia/standards-staging#426 * Fixed typos * Standards Maintenance Issue #652: Updated description of AmountString field clarifying the currency format and noting it defaults to AUD * adding 'and' for one hundred 'and' twenty-three dollars * Minor update to styling and wording * Fix link for local build testing * Added x-version-notes and x-diff custom extension keys. x-version-notes allows capturing API version notes. x-diff allows capturing diff statements against specific API or schemas * Standards Maintenance Issue #653: Amended description of dailySupplyChargeType field * Standards Maintenance Issue #653: Fixed incorrect diff statement * Staging #438 - Improve code samples Addresses: ConsumerDataStandardsAustralia/standards-staging#438 * Version delta and release notes * Staging #437 - Remove Known Issues Addresses: ConsumerDataStandardsAustralia/standards-staging#437 * Corrected error title Addresses: ConsumerDataStandardsAustralia/standards-staging#411 (comment) * Update _errors.md * Corrected quotes in JSON samples * Added Register Base URLs to spec * Updated links * Added TLS changes to align with BCP 195 and FAPI 2.0. Addresses issue: ConsumerDataStandardsAustralia/standards-maintenance#648 * Removed x-diff custom key from json swagger. Moved diff statement into energy erb file * BCP195 as one word, bolded key words * Update "account id" to "accountId" * Removed bold styling * Update to validation version only Clearly distinguishing the specific JAR versions used in each step of the build process and updated to the newer JAR for validation only. * Reverted non-RateString changes * Updated notes * Update issue title * Resolve release notes and change log * 1.32.0 build for Staging * Build 1.32.0 --------- Co-authored-by: Mark Verstege <[email protected]> Co-authored-by: Hemang Rathod <[email protected]>
Incorporated into Standards v1.32.0. |
This change request has been created to simplify the raising of minor changes, such as text corrections or description clarifications, that are not really material to the standards but do have a real impact on readability and clarity.
Please raise any such suggestions that you would like included in Maintenance Iteration 20 on this issue and the DSB will review them. If a suggestion is a material change a dedicated CR will be raised.
The text was updated successfully, but these errors were encountered: