Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAPI 1.0 Final Phase 3 Obligation example for authorisation request using the Authorisation Code Flow does not have "response_mode" attribute #559

Closed
AG-IAM opened this issue Nov 28, 2022 · 6 comments
Labels
Documentation Improvements, additions or queries related to documentation Proposal made The DSB has proposed a specific change to the standards to address the change request Security Change or question related to the information security profile
Milestone

Comments

@AG-IAM
Copy link

AG-IAM commented Nov 28, 2022

Description

For FAPI 1.0 Final Phase 3 Obligations, the Non-Normative Example Utilising FAPI 1.0 Final, PAR RFC9126, PKCE, JARM and Authorization Code Flow does not have "response_mode" attribute in the decoded request. The "response_mode" attribute will be identified by Authorisation server to provide the corresponding authorisation response. Without this attribute, the code will be sent directly as a query parameter and not in a signed/encrypted JWT. Is this the expected behaviour? if yes, the documentation needs to be updated with the attribute "response_mode" as Optional and expected response for authorisation code Flow and authorisation code Flow with JARM.

Area Affected

https://consumerdatastandardsaustralia.github.io/standards/?examples#security-endpoints > Pushed Authorisation End Point > Decoded Request - FAPI 1.0 Final Phase 3 Obligation
image

Change Proposed

Update non-normative example for FAPI 1.0 Final Phase 3 Obligations to include "response_mode" in the Decoded Request or update the documentation with the expected response for authorisation code Flow and authorisation code Flow with JARM.

DSB Proposed Solution

The current DSB proposal for this issue is in #559 (comment)

@nils-work nils-work added Documentation Improvements, additions or queries related to documentation Security Change or question related to the information security profile labels Feb 3, 2023
@CDR-API-Stream
Copy link
Collaborator

Hi @AG-IAM, this looks like a documentation fix to include the response_mode. Aligning to the FAPI 1 Advanced profile, the response_mode is jwt.

@markverstege
Copy link
Member

This change has been staged for review: ConsumerDataStandardsAustralia/standards-staging@release/1.24.0...maintenance/559

Note it is compared against the previous release. At present no draft 1.25.0 release has been staged but it is expected this change will target 1.25.0 for release at the end of maintenance iteration 15.

@CDR-API-Stream CDR-API-Stream moved this from Iteration Candidates to In Progress: Staging in Data Standards Maintenance May 17, 2023
@CDR-API-Stream CDR-API-Stream added the Proposal made The DSB has proposed a specific change to the standards to address the change request label May 17, 2023
@biza-io
Copy link

biza-io commented May 30, 2023

Biza accepts this non-normative example update to reflect a valid request for a response_type=code authorisation in FAPI. The default response_mode for response_type=code is fragment as per Final: OAuth 2.0 Multiple Response Type Encoding Practices which makes the current example invalid for authorisation servers complying with FAPI 1.0 Advanced profile.

@markverstege
Copy link
Member

Hi @biza-io, the staged non-normative example should address your feedback when JARM is used in combination with Authorization Code Flow. FAPI 1.0 Advanced states that response_mode of jwt be used which is reflected in the staged non-normative example.

@CDR-API-Stream CDR-API-Stream moved this from In Progress: Staging to Awaiting Chair Approval in Data Standards Maintenance Jun 29, 2023
@CDR-API-Stream CDR-API-Stream moved this from Awaiting Chair Approval to In Progress: Staging in Data Standards Maintenance Jun 29, 2023
@CDR-API-Stream CDR-API-Stream moved this from In Progress: Staging to Awaiting Chair Approval in Data Standards Maintenance Jun 29, 2023
@nils-work
Copy link
Member

@nils-work nils-work added this to the 1.25.0 milestone Jul 10, 2023
@nils-work
Copy link
Member

Standards version 1.25.0 has now been published, incorporating this change.

@github-project-automation github-project-automation bot moved this from Awaiting Chair Approval to Done in Data Standards Maintenance Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements, additions or queries related to documentation Proposal made The DSB has proposed a specific change to the standards to address the change request Security Change or question related to the information security profile
Projects
Status: Done
Development

No branches or pull requests

5 participants