-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an unauthenticated GetDataHolderBrands endpoint exposed as a public API #444
Comments
If Option 1 is being evaluated there should also be a consideration for payload integrity verification. |
During Maintenance Iteration 10 collaboration, it was identified that one of the key use-cases for having a public GetDataHolderBrands API is to allow public clients to discover data holders in the CDR and their respective product reference data, status, and outage endpoints. Option 2 could be conceivably constrained in scope to target this use case. |
A significant use case for an unauthenticated endpoint to share Data Holder information is discovery of Product Reference Data (PRD) endpoints. DSB/Treasury have expressed a desire for each Energy data holder to implement their own endpoint for serving up PRD, just like the banking sector. The The The obligation to share PRD prior to consumer data sharing was in place for the banking sector and is also in place for the energy sector, and appears to be a pattern that will be used for each industry moving forward. Therefore, in order for the Register to be used to discover PRD endpoints, only a subset of information needs to be collected from data holders. The CDR on-boarding process is currently catering for consumer data sharing obligations, not PRD obligations. The question then arises: how can PRD endpoints be made available via the Register (both prior to and after the consumer data sharing obligations of a data holder brand) to allow discovery and use by interested participants? The ACCC proposes adding another API endpoint to the Register: This endpoint would not replace the The proposed endpoint will return the following data:
Options
Considerations
|
Thanks for taking the time to assess the issue and develop a proposed solution. Stay or Go is supportive of Option 1 proposed above - i.e. the create a new API, With regard to the This has obviously been a significant gap and oversight for 2-3 years since the PRD endpoints were first implemented in the banking industry, so we request this change be ranked as an absolute priority for implementation Waiting until the end of the year, when Energy is to be implement, is not really acceptable in our mind. |
Given conversations during the maintenance iteration, the ACCC would like to make it clear that if it is not acceptable for brandId to be optional, this item will need to be delayed until a time that the ACCC can assess a solution where this would be achievable. |
With regard to If faced with the above choice, I'd recommend delivering V1 of the API in one month's time without the Not having Not having the API at all make the PRD largely unusable, and certainly unreliable. |
Collaboration on this issue through maintenance iteration 10, has resulted in the following DSB proposal, expanding off of @ACCC-CDR's initial proposal. Rather than duplicate the GetDataHolderBrands API for unauthenticated clients, a new API optimised for discovery of public data holder APIs (PRD, status, and outage and any future public endpoints) will be defined named: The schema will be optimised for presentation of Data Holder Brands and discovery of associated public endpoints. It will therefore have the following fields:
The payload will be a shortened version of the data holder brands payload with a flat simplified structure. The industries array will follow the same convention as GetDataHolderBrands https://consumerdatastandardsaustralia.github.io/standards/#tocSregisterdataholderbrand. Only one industry will initially be supported until multiple industry sectors per brand are supported on the CDR Register. Discussion has occurred on whether the brandId can remain optional until the CDR Register is able to guarantee the field will be populated. The DSB does not seek to define an interim solution in the standards. This leaves the responsibility to the ACCC to coordinate the release of this API based on their release schedules. Any interim solution will also remain the responsibility of the ACCC. |
Feedback we have received from the ACCC indicates they will not be able to specify a delivery date for the proposed solution and an interim solution will be required. As highlighted from ACCC's feedback, a mandatory Feedback from industry during MI 10 has highlighted that an interim solution that provides a mandatory unique identifier in addition to the In order to give the ACCC flexibility in delivering the full solution, provide partial value to API clients, and to simplify the reading of the standards, the DSB has decided to propose an interim solution. ProposalBased on the feedback received from stakeholders, the DSB proposes the following:
This logic will provide a transition period, allowing clients to migrate records from referencing the Interim Solution (V1) - targeted latest dependency date of 01st October 2022
Complete Solution (V2) - targeted release to be assessed in a future maintenance iteration
|
This approach look fine. Key to success is to deliver the interim solution quickly. Thanks |
The ACCC reiterates it’s previous commentary that if the solution the ACCC has previously proposed is not accepted then we’ll be unable to commit to a 1st of October 2022 delivery date. The ACCC does not support the inclusion of an |
This sounds a lot like hostage taking by the regulator, perhaps if the ACCC engaged the community earlier it wouldn't be facing timeline issues. October is 6 months away, that's the time accepted by all the other participants in the ecosystem, I find it pretty hypocritical for the ACCC to enforce FDO obligations, request shorter timelines on Participants and then not accept the convention for its own delivery.
Is the ACCC honestly suggesting that these records don't already have a database identifier associated with them? If there isn't an identifier already present how else would the ACCC be administering the records? Hand coding them? Smoke signals from some tower in Canberra? I thought the
I was at the last maintenance call and I don't believe ACCC bothered to show up, perhaps it should have. If the ACCC is going to throw its toys out of the pram whenever it doesn't get what it wants then perhaps the Minister should be called in to resolve who exactly is responsible for Register related Standards since it seems increasingly ambiguous. It isn't a reasonable nor sustainable solution for non-government technical implementers trying to plan activities based on guidance from multiple government bodies on delivery timelines that are, in the Register case, quite opaque. |
Just want to highlight again that this API is already close to 3 years late - i.e. it should have been delivered on 1-Jul-2019 when the first PRD APIs were launched. Waiting another 6 months for this API really isn't an acceptable outcome for the industry or the success of the CDR. This is a very simple API and shouldn't take more than a week to build. We therefore request that it be priorities and delivered within the next 4 weeks. Happy to have a conversation with the ACCC (assuming they are responsible for building the API) if technical advice is required. Regarding the |
To summarise, the contention remained that the With this being considered, the DSB’s position remained unchanged as the interim solution shares the implementation burden between the CDR Register and clients until the complete solution is available. No other solution has been proposed which is seen as fit for purpose. The 1 October 2022 delivery date proposed is the latest that this API can be released and provide meaningful value to the CDR. Later delivery will erode the value of this API as industry may look for alternative sources for discovery. Earlier delivery will increase the value of this API as it will increase the period unauthenticated clients are able to leverage its value and increase confidence that the CDR Register is the source of truth in the CDR.
Release v1.17.0. for the CDS incorporates the interim solution (V1) into the standards. Issue #518 has been raised to track delivery of the Complete Solution (V2) Please refer to Decision 237 for further details. |
Description
As part of the API Uplift for Data Holder Multi-Sector support #424, there are considerations to be made on how the GetDataHolderBrands endpoint can be augmented to allow unauthenticated client access.
This piece of work has been extracted into its own change request to allow this topic to be considered beyond maintenance iteration 9.
Area Affected
Register APIs will need to be structured to expose GetDataHolderBrands information from a public API
Change Proposed
The following changes are proposed:
• Default: All data holder brands will be returned
• Query parameter filter: allow filtering by industry sector
Options:
Create an unauthenticated Data Holder Brands API returning the same content as the current authenticated API. The authenticated version of the API will be deprecated once a schedule has been determined
Create an unauthenticated Data Holder Brands API returning a subset of the content currently returned in the authenticated API. Security endpoint information would NOT be included in this API. Both the authenticated and unauthenticated APIs would be maintained.
Considerations:
The text was updated successfully, but these errors were encountered: