rails 6 support

[modosc]

right now rails 6 is excluded here, are there plans to test compatibility out?

[ngouy]

I tried to do so (forked it and update dependencies). Sadly because of rails/rails#36638 it's not possible for now

[ngouy]

please note the following working with an updated version of this gem with right dependencies.

While preload is still working, The preload_scope is not working anymore.

for now, I figured it out with :

# frozen_string_literal: true

module Extensions
  class OrderedExtension < BaseExtension
    DEFAULT_SCOPE = :ordered

    def after_resolve(value:, **_)
      scope = options.fetch(:scope, DEFAULT_SCOPE)
      value&.send(scope)
    end
  end
end

class myType < BaseType
 # ...
 field :has_many_stuffs, [StuffType], preload: [:whatever], extensions: [Extensions::OrderedExtension]
 field :has_many_other_stuffs, [StuffType], preload: [:whatever] do
    extension(Extensions::RoundedExtension, scope: :active)
 end

This requires some modifications into the extension if you want to have many scopes and call extension(Extensions::RoundedExtension, scope: [:ordered, :active])

[justisb]

FYI @ngouy in your fork the ActiveRecord dependency change is too restrictive- currently <= 6 locks Rails at exactly 6.0.0, so cannot be updated to 6.0.1.

I removed the upper bound here which allows updating Rails minor versions again: https://github.com/Popmenu/graphql-preload/commit/5499986aad1cf07d9db897dcdb5846068bd0cd43

[ngouy]

nice catch. Fixed

[Envek]

Here is workaround for changed ActiveRecord's preloading by my colleagues:
https://gist.github.com/ssnickolay/f171ae9b4e71fd36686989ef7063bc89

Here I adopted it to my fork: Envek@e868b8d (@ngouy, feel free to cherry-pick it to yours).

I tested it with my micro test suite from #14 and in my project's branch for Rails 6 upgrade and it works.

[Envek]

Preloading seems to be fixed in latest Rails 6 (will be released in 6.0.4) and master: rails/rails#40056