Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line flag to enable Key Manager API #448

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

joaquim-verges
Copy link
Contributor

First PR that starts introducing the Key Manager API as discussed in #439

This introduces the boolean command line flag that controls whether or not to enable the new API.

@jframe
Copy link
Contributor

jframe commented Nov 22, 2021

Your build is failing due to the formatting errors in the spotless check. You can run ./gradlew spotlessApply to fix the formatting issue.

Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Just need to fix formatting again for spotless

@joaquim-verges
Copy link
Contributor Author

Should have ran it after the string change 😅 Done.

@jframe jframe merged commit f2c8cee into Consensys:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants