Makre sure ArtifactSignerProvider list is non null

Consensys · Oct 16, 2024 · 9c7a565 · 9c7a565
1 parent 373a523
commit 9c7a565
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/core/src/main/java/tech/pegasys/web3signer/core/Runner.java b/core/src/main/java/tech/pegasys/web3signer/core/Runner.java
@@ -112,7 +112,7 @@ public void run() {
     healthCheckHandler = HealthCheckHandler.create(vertx);
 
     final List<ArtifactSignerProvider> artifactSignerProvider =
-        createArtifactSignerProvider(vertx, metricsSystem);
+        Optional.ofNullable(createArtifactSignerProvider(vertx, metricsSystem)).orElse(List.of());
 
     try {
       createVersionMetric(metricsSystem);
@@ -183,9 +183,7 @@ public void run() {
 
       closeables.add(() -> shutdownVertx(vertx));
     } catch (final Throwable e) {
-      if (artifactSignerProvider != null) {
-        artifactSignerProvider.forEach(ArtifactSignerProvider::close);
-      }
+      artifactSignerProvider.forEach(ArtifactSignerProvider::close);
       shutdownVertx(vertx);
       metricsService.ifPresent(MetricsService::stop);
       LOG.error("Failed to initialise application", e);