Starting from transitioned initial anchor with tests #8221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import tech.pegasys.teku.spec.schemas.SchemaDefinitionsBellatrix; | ||
| import tech.pegasys.teku.spec.util.DataStructureUtil; | ||
|
|
||
| class MiscHelpersBellatrixTest { |
Check notice
Code scanning / CodeQL
Unused classes and interfaces Note test
2 tasks
gfukushima
reviewed
Oct 29, 2024
| @@ -69,6 +69,7 @@ public void handleRequest(RestApiRequest request) throws JsonProcessingException | |||
| request.header(Header.CACHE_CONTROL, CACHE_NONE); | |||
|
|
|||
| final String blockId = request.getPathParameter(PARAMETER_BLOCK_ID); | |||
| // FIXME: not sure. Are we ok to return here transitioned state on keyword finalized? | |||
There was a problem hiding this comment.
my understand is that this is ok since this endpoint should mimic the same behaviour as the /eth/v2/debug/beacon/states/{state_id} but allowing to search for block. We're using the same blockroot for the transitioned state so it looks logical to me that we returned the transitioned state
| @@ -375,6 +376,7 @@ private Optional<ReorgContext> computeReorgContext( | |||
| return optionalReorgContext; | |||
| } | |||
|
|
|||
| // TODO: Test the consequences of having transitioned chainHead | |||
There was a problem hiding this comment.
why would we transition the chainHead? I thought we were only going to transition finalized states/block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Based on #7981
Work in progress.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog