Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PostBlock for Deneb #7188

Merged
merged 10 commits into from
May 31, 2023
Merged

Update PostBlock for Deneb #7188

merged 10 commits into from
May 31, 2023

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented May 29, 2023 •
edited
Loading

PR Description

  • Make PostBlock and PostBlindedBlock use the SignedBlockContainer schemas from SchemaDefinitions

Fixed Issue(s)

fixes #7013
fixes #7075

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov marked this pull request as draft May 29, 2023 13:07
@StefanBratanov StefanBratanov changed the title Update GetBlock and PostBlock for Deneb Update PostBlock for Deneb May 29, 2023
@StefanBratanov StefanBratanov force-pushed the update_get_block_and_post_block_deneb branch 2 times, most recently from eff21af to 4ae2da6 Compare May 30, 2023 14:01
@StefanBratanov StefanBratanov marked this pull request as ready for review May 30, 2023 14:01
@StefanBratanov StefanBratanov force-pushed the update_get_block_and_post_block_deneb branch from 5f38c4a to 474c705 Compare May 30, 2023 14:22
@StefanBratanov StefanBratanov force-pushed the update_get_block_and_post_block_deneb branch from 474c705 to bf89321 Compare May 31, 2023 06:05
rolfyone
rolfyone approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov merged commit ab0414f into Consensys:master May 31, 2023
@StefanBratanov StefanBratanov deleted the update_get_block_and_post_block_deneb branch May 31, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the PostBlindedBlock API Update the PostBlock endpoint
2 participants
@StefanBratanov @rolfyone